perf: don't read chunk when checking existence #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chunks can be MBs in size. We should not force a read from DB when it's not cached already. Also alters the `chunk_exists` method to check the cache first. An `exists` call on the DB is still more expensive than looking up an `Arc` in the in-memory cache.
nikurt
approved these changes
Sep 21, 2023
nikurt
pushed a commit
that referenced
this pull request
Sep 22, 2023
Chunks can be MBs in size. We should not force a read from DB when it's not cached already. Also alters the `chunk_exists` method to check the cache first. An `exists` call on the DB is still more expensive than looking up an `Arc` in the in-memory cache.
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
Chunks can be MBs in size. We should not force a read from DB when it's not cached already. Also alters the `chunk_exists` method to check the cache first. An `exists` call on the DB is still more expensive than looking up an `Arc` in the in-memory cache.
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2023
Chunks can be MBs in size. We should not force a read from DB when it's not cached already. Also alters the `chunk_exists` method to check the cache first. An `exists` call on the DB is still more expensive than looking up an `Arc` in the in-memory cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunks can be MBs in size. We should not force a read from DB when it's not cached already.
Also alters the
chunk_existsmethod to check the cache first. Anexistscall on the DB is still more expensive than looking up anArcin the in-memory cache.